Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Radius to CandleSticks #610

Closed
elliotaplant opened this issue Aug 7, 2018 · 1 comment
Closed

Add Radius to CandleSticks #610

elliotaplant opened this issue Aug 7, 2018 · 1 comment

Comments

@elliotaplant
Copy link

I have a design need to add a border radius to the candlesticks in the CandleStickSeries component. I see two ways of doing this:

  1. Add a candleBorderRadius prop to the CandleStickSeries that gets passed along as rx and ry to the candle <rect />
  2. Add wickProps and candleProps props to the CandleStickSeries that get passed along and spread on the wick and candle respectively.

I'll make two PR's with updates to the components and docs for anyone that wants to see the code in detail.

@rrag
Copy link
Owner

rrag commented Sep 4, 2018

Thanks for the PRs, but I am not going to accept them for reasons mentioned in the PRs.

Thank you for your effort, sorry I could not merge it but
performance of candlestick chart is very important for me to compromise

@rrag rrag closed this as completed Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants