This repository has been archived by the owner. It is now read-only.

set HAS_RUN_BSB after bsb is done. #31

Merged
merged 1 commit into from Sep 30, 2017

Conversation

2 participants
@tcoopman
Copy link
Contributor

tcoopman commented Sep 30, 2017

Before, you set __HAS_RUN_BSB__ immediatly to true, so when you enter multiple times in runBsb you might resolve too soon, resulting in an error, because the compilation hasn't actually been done.

set HAS_RUN_BSB after bsb is done.
Before, you set `__HAS_RUN_BSB__` immediatly to true, so when you enter multiple times in `runBsb` you might resolve too soon, resulting in an error, because the compilation hasn't actually been done.
@rrdelaney

This comment has been minimized.

Copy link
Owner

rrdelaney commented Sep 30, 2017

Hey @tcoopman! Thanks so much for this PR 😄

This was a definite oversight, thanks for fixing it!

@rrdelaney rrdelaney merged commit df1fe17 into rrdelaney:master Sep 30, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@tcoopman

This comment has been minimized.

Copy link
Contributor

tcoopman commented Sep 30, 2017

I was just thinking that there is a potential downside to mix fix. You might get multiple instances of bsb running now :-( I'm not sure how much of a real problem this is with bsb being so fast and all, but this is something that might need to be fixed as well?

@rrdelaney

This comment has been minimized.

Copy link
Owner

rrdelaney commented Sep 30, 2017

Yea, I'm going to add something to alleviate that before I release 👍

@rrdelaney

This comment has been minimized.

Copy link
Owner

rrdelaney commented Oct 1, 2017

Should be published in v1.8.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.