From c58c913330dea7923a8d32472b8cf61b4cfa333e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9mi=20Pr=C3=A9vost?= Date: Tue, 20 Aug 2019 09:33:04 -0400 Subject: [PATCH] Fix name parsing bug in Credo.Check.Consistency.UnusedVariableNames --- lib/credo/check/consistency/unused_variable_names/collector.ex | 2 +- test/credo/check/consistency/unused_variable_names_test.exs | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/credo/check/consistency/unused_variable_names/collector.ex b/lib/credo/check/consistency/unused_variable_names/collector.ex index 42b3598a5..f7b317ec6 100644 --- a/lib/credo/check/consistency/unused_variable_names/collector.ex +++ b/lib/credo/check/consistency/unused_variable_names/collector.ex @@ -40,7 +40,7 @@ defmodule Credo.Check.Consistency.UnusedVariableNames.Collector do defp unused_variable_name?({:_, _, _}), do: true - defp unused_variable_name?({name, _, _}), + defp unused_variable_name?({name, _, _}) when is_atom(name), do: String.starts_with?(Atom.to_string(name), "_") defp unused_variable_name?(_), do: false diff --git a/test/credo/check/consistency/unused_variable_names_test.exs b/test/credo/check/consistency/unused_variable_names_test.exs index 1e94e5787..a85f66cbe 100644 --- a/test/credo/check/consistency/unused_variable_names_test.exs +++ b/test/credo/check/consistency/unused_variable_names_test.exs @@ -9,6 +9,7 @@ defmodule Credo.Check.Consistency.UnusedVariableNamesTest do defmodule Credo.SampleOne do defmodule Foo do def bar(_, %{foo: foo} = _, _) do + version = Mix.Project.config()[:version] end end end