From d9474a115b0527283b70a0acc39f4d8d7baf0775 Mon Sep 17 00:00:00 2001 From: Lucas Reis Date: Wed, 31 Mar 2021 15:07:55 -0300 Subject: [PATCH] Fixing issue #866 to check predicates with arity --- .../readability/predicate_function_names.ex | 2 +- .../predicate_function_names_test.exs | 20 +++++++++++++++++++ 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/lib/credo/check/readability/predicate_function_names.ex b/lib/credo/check/readability/predicate_function_names.ex index a455478a8..b7eacf214 100644 --- a/lib/credo/check/readability/predicate_function_names.ex +++ b/lib/credo/check/readability/predicate_function_names.ex @@ -77,7 +77,7 @@ defmodule Credo.Check.Readability.PredicateFunctionNames do defp issues_for_definition(op, body, issues, issue_meta) do case Enum.at(body, 0) do - {name, meta, nil} -> + {name, meta, _} -> issues_for_name(op, name, meta, issues, issue_meta) _ -> diff --git a/test/credo/check/readability/predicate_function_names_test.exs b/test/credo/check/readability/predicate_function_names_test.exs index 23283e646..7f4ddf9e5 100644 --- a/test/credo/check/readability/predicate_function_names_test.exs +++ b/test/credo/check/readability/predicate_function_names_test.exs @@ -44,4 +44,24 @@ defmodule Credo.Check.Readability.PredicateFunctionNamesTest do |> run_check(@described_check) |> assert_issues() end + + test "it should report a violation with arity" do + """ + def is_valid?(a) do + end + """ + |> to_source_file + |> run_check(@described_check) + |> assert_issue() + end + + test "it should report a violation with arity /2" do + """ + def is_valid(a) do + end + """ + |> to_source_file + |> run_check(@described_check) + |> assert_issue() + end end