New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analysis of checks in regards to Elixir versions #505

Open
josevalim opened this Issue Feb 12, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@josevalim
Contributor

josevalim commented Feb 12, 2018

Outdated by warnings in the compiler (since v1.4):

  • name_redeclaration_by_assignment.ex
  • name_redeclaration_by_case.ex
  • name_redeclaration_by_fn.ex

Outdated by the formatter in Elixir v1.6:

  • line_endings.ex
  • space_around_operators.ex
  • space_in_parentheses.ex
  • tabs_or_spaces.ex
  • large_numbers.ex
  • max_line_length.ex
  • parentheses_in_condition.ex
  • prefer_unquoted_atoms.ex
  • redundant_blank_lines.ex
  • semicolons.ex
  • space_after_commas.ex
  • trailing_blank_line.ex
  • trailing_white_space.ex

Will be solved in Elixir v1.7:

  • lazy_logging.ex

Checks that have a high false positive rate (IMO):

  • append_single_item.ex
  • case_trivial_matches.ex
  • pipe_chain_start.ex
@coreyhaines

This comment has been minimized.

coreyhaines commented Mar 5, 2018

It appears that lazy_logging.ex is solved via the macro in Elixir 1.6.2.
https://github.com/elixir-lang/elixir/blob/v1.6.2/lib/logger/lib/logger.ex#L746-L754

@josevalim josevalim referenced this issue May 11, 2018

Merged

Optimized indexer #162

4 of 4 tasks complete

KronicDeth added a commit to poanetwork/blockscout that referenced this issue May 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment