New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some refactoring opportunity warnings #590

Merged
merged 1 commit into from Oct 4, 2018

Conversation

Projects
None yet
2 participants
@michaelstalker
Contributor

michaelstalker commented Oct 3, 2018

Running mix credo on the Credo codebase revealed several "Refactoring opportunity" warnings. This commit fixes some of them. Except for removing the tasks temporary variable in lib/credo/execution/process_definition.ex, I tried keeping the changes in this PR limited to what would eliminate some refactoring opportunity warnings.

All tests still pass.

Fix some refactoring opportunity warnings
Running `mix credo` on the Credo codebase revealed several "Refactoring
opportunity" warnings. This commit fixes some of them. Except for
removing the `tasks` temporary variable in
`lib/credo/execution/process_definition.ex`, I tried keeping the changes
in this PR limited to what would eliminate some refactoring opportunity
warnings.

@rrrene rrrene merged commit 53734a2 into rrrene:master Oct 4, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@rrrene

This comment has been minimized.

Show comment
Hide comment
@rrrene

rrrene Oct 4, 2018

Owner

@michaelstalker Thank you! 👍

Owner

rrrene commented Oct 4, 2018

@michaelstalker Thank you! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment