New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug on counting function calls in ABC #606

Merged
merged 2 commits into from Dec 28, 2018

Conversation

Projects
None yet
2 participants
@roehst
Copy link
Contributor

roehst commented Oct 29, 2018

The {atom, _, list} pattern matches function calls but
was not counting any points as branches in the B component
of the metric.

This commit fixes it.

Also, I had to add a whitelist (@non_calls) so that :__aliases__,
:__block__ and other constructs that syntactically are functions
calls are properly skipped.

I added two tests to check for the new cases.

roehst added some commits Oct 29, 2018

Fix bug on counting function calls in ABC
The {atom, _, list} pattern matches function calls but
was not counting any points as branches in the B component
of the metric.

This commit fixes it.

Also, I had to add a whitelist (@non_calls) so that :__aliases__,
:__block__ and other constructs that syntactically are functions
calls are properly skipped.

I added two tests to check for the new cases.
@roehst

This comment has been minimized.

Copy link
Contributor

roehst commented Oct 29, 2018

Refers to #602

@rrrene rrrene merged commit cb1d8cf into rrrene:master Dec 28, 2018

1 of 2 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rrrene

This comment has been minimized.

Copy link
Owner

rrrene commented Dec 28, 2018

@roehst Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment