Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add :allow_bang :params to @ explanation of VariableRebinding check #647

Merged
merged 1 commit into from Apr 21, 2019

Conversation

Projects
None yet
2 participants
@SpaceEEC
Copy link
Contributor

commented Apr 2, 2019

The :allow_bang option wasn't added to :params of the @explanation attribute of Credo.Check.Refactor.VariableRebinding resulting in the option/parameter not being included in the configuration options:

┃    __ CONFIGURATION OPTIONS
┃
┃       You can disable this check by using this tuple
┃
┃         {Credo.Check.Refactor.VariableRebinding, false}
┃
┃       There are no other configuration options.

After adding the option the output is as expected:

┃    __ CONFIGURATION OPTIONS
┃
┃       To configure this check, use this tuple
┃
┃         {Credo.Check.Refactor.VariableRebinding, <params>}
┃
┃       with <params> being false or any combination of these keywords:
┃
┃         allow_bang:            Variables with a bang suffix will be ignored.

@rrrene rrrene merged commit 9376544 into rrrene:master Apr 21, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rrrene

This comment has been minimized.

Copy link
Owner

commented Apr 21, 2019

@SpaceEEC Thx! 👍

@SpaceEEC SpaceEEC deleted the SpaceEEC:variable_binding_params branch Apr 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.