Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes issue #696 #697

Merged
merged 3 commits into from Sep 1, 2019

Conversation

@ityonemo
Copy link
Contributor

commented Aug 31, 2019

sometimes it's useful (but, of course, potentially dangerous) to redefine an "@" parameter inside of a using statement. This form currently gets trapped by credo. I attempted a strategy of trapping on the outer context being a defmacro statement, but this strategy wound up being simpler. In general, the "@" AST will not be followed by a bracket except in this singular situation.

@ityonemo

This comment has been minimized.

Copy link
Contributor Author

commented Aug 31, 2019

for certain DSLs, not warning on operator defines is useful (e.g. linear algebra dsl which overrides + - *)

@rrrene rrrene merged commit 56ebbef into rrrene:master Sep 1, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.