Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic issue with PipeChainStart, excluding :atoms, and nil. Fixes #712 #713

Merged
merged 1 commit into from Nov 26, 2019

Conversation

@TheFirstAvenger
Copy link
Contributor

TheFirstAvenger commented Nov 6, 2019

Fixed logic issue with PipeChainStart when excluding :atom and using a nil. See #712.

case arguments do
[nil | _] -> [:atom]
x -> x |> List.first() |> argument_type()
end
Comment on lines +208 to +211

This comment has been minimized.

Copy link
@rrrene

rrrene Nov 23, 2019

Owner

Wouldn't it be easier to edit this line to return [:atom]?

This comment has been minimized.

Copy link
@TheFirstAvenger

TheFirstAvenger Nov 23, 2019

Author Contributor

I believe that would change the logic from the current logic which returns an empty list when there are no found argument types.

This comment has been minimized.

Copy link
@rrrene

rrrene Nov 26, 2019

Owner

You are right.

@rrrene rrrene merged commit 4ed2f40 into rrrene:master Nov 26, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.