New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added exit_status to command line and check on suggest #31

Merged
merged 1 commit into from Aug 6, 2015

Conversation

Projects
None yet
2 participants
@spk
Contributor

spk commented Jul 26, 2015

Exit status stay zero by default, but for suggest return above zero when suggestions are found.
Can be useful for CI check.

@spk

This comment has been minimized.

Contributor

spk commented Jul 26, 2015

Look like the build is failing from things not related to my changes ?

@rrrene

This comment has been minimized.

Owner

rrrene commented Jul 28, 2015

Hi, great idea 👍

I will merge this as soon as I get around to it (currently a bit under the weather).

@spk

This comment has been minimized.

Contributor

spk commented Jul 28, 2015

Hi, thanks !

rrrene added a commit that referenced this pull request Aug 6, 2015

Merge pull request #31 from spk/exit-status
Add exit_status to command line and check on suggest

@rrrene rrrene merged commit dcbbc19 into rrrene:master Aug 6, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@spk

This comment has been minimized.

Contributor

spk commented Aug 6, 2015

Nice thanks.

@spk spk deleted the spk:exit-status branch Aug 6, 2015

@rrrene

This comment has been minimized.

Owner

rrrene commented Aug 6, 2015

It will be relased in 0.7.0 as backwards-incompatible change, since this might break &&-based workflows. 👍

@spk

This comment has been minimized.

Contributor

spk commented Aug 6, 2015

Yes did not think of that, since I usually use inch directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment