Add some security around wrongly typed URL argument

SDWebImage · Sep 6, 2012 · 4052487 · 4052487
1 parent 5f27d2d
commit 4052487
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/SDWebImage/SDWebImageManager.m b/SDWebImage/SDWebImageManager.m
@@ -123,6 +123,10 @@ - (void)downloadWithURL:(NSURL *)url delegate:(id<SDWebImageManagerDelegate>)del
     {
         url = [NSURL URLWithString:(NSString *)url];
     }
+    else if (![url isKindOfClass:NSURL.class])
+    {
+        url = nil; // Prevent some common crashes due to common wrong values passed like NSNull.null for instance
+    }
 
     if (!url || !delegate || (!(options & SDWebImageRetryFailed) && [failedURLs containsObject:url]))
     {