Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to specify preflight response status code #121

Merged
merged 4 commits into from Nov 18, 2021

Conversation

Neurostep
Copy link
Contributor

@Neurostep Neurostep commented Nov 18, 2021

Description

In the recent version (v1.8.0) there was added a change that potentially might break the clients that mistakenly relied on HTTP response code as 200 only (or other exotic behavior). Although, the specification does not provide the recommended status code for the preflight response, some of the clients (old browsers and/or SmartTVs) will choke on 204.

In this PR we provide a way to specify the status code to use for successful OPTIONS requests in a similar way it does so in expressjs.

Along with the above changes, there is also a missing status code set for the Martini compatible handler which is fixed as well.

Related

@rs rs merged commit 27c7ce4 into rs:master Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants