New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing test, fixes GH #8 #10

Merged
merged 1 commit into from Jan 2, 2016

Conversation

Projects
None yet
2 participants
@xsawyerx
Contributor

xsawyerx commented Jan 2, 2016

As described in GH #8, there is a failing test which appears to call response twice. The first time succeeds (and if quit is called right after, that succeeds too).

The second time, however, called explicitly, it fails with a time-out (since the server probably already responded and has nothing more to respond). The following call to quit then fails too.

I would be happy if someone with more experience will review this to make sure I'm not wrong.

(This PR is part of PRC.)

Fix failing test, fixes GH #8:
As described in GH #8, there is a failing test which appears to
call `response` twice. The first time succeeds (and if `quit` is
called right after, that succeeds too).

The second time, however, called explicitly, it fails with a
time-out (since the server probably already responded and has
nothing more to respond). The following call to `quit` then fails
too.

guimard added a commit that referenced this pull request Jan 2, 2016

@guimard guimard merged commit f206ea4 into rs:master Jan 2, 2016

@xsawyerx xsawyerx referenced this pull request Jan 2, 2016

Closed

Test `lmtp.t` fails #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment