New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/modern conventions #11

Merged
merged 2 commits into from Jan 2, 2016

Conversation

Projects
None yet
2 participants
@xsawyerx
Contributor

xsawyerx commented Jan 2, 2016

Use a few modern conventions.

  • Direct method constructor (in the code, the examples, the POD, and the tests).
  • Warnings on all modules.

xsawyerx added some commits Jan 2, 2016

Use constructor as a direct method:
The indirect method style (`new Class`) is not recommended, so
this commit replaces it with direct method style (`Class->new`).

Further references:

http://www.modernperlbooks.com/mt/2009/08/the-problems-with-indirect-object-notation.html
http://perldoc.perl.org/perlobj.html (under "Indirect Object syntax")
http://shadow.cat/blog/matt-s-trout/indirect-but-still-fatal/
Add warnings to all packages:
The warnings pragma is considered a common practice. One package
already uses it. This adds it to all the rest.

guimard added a commit that referenced this pull request Jan 2, 2016

@guimard guimard merged commit 5385df0 into rs:master Jan 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment