Prevent removing of (Required,Default) fields in HTTP PUT. Fixes #174 #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smyrman
reviewed
Nov 27, 2018
smyrman
reviewed
Nov 27, 2018
smyrman
reviewed
Nov 27, 2018
There was a problem hiding this comment.
Looks good to me; thanks for answering my question. I can buy into your arguments. Would you be able to add a small note about PUT in the main README, and how it works?
I suppose in particular that the original value of objects are kept on PUT requests if the field has a default value, or is read-only; all other fields are cleared. Is this the correct understanding btw?
smyrman
reviewed
Nov 27, 2018
Dragomir-Ivanov
force-pushed
the
master
branch
from
d4a819c
to
85a562b
Compare
|
Done. Don't know if changed README as you imagined, but will fix :) |
smyrman
reviewed
Nov 29, 2018
rs
previously approved these changes
Nov 29, 2018
Dragomir-Ivanov
force-pushed
the
master
branch
from
85a562b
to
a5f7453
Compare
|
@smyrman Done. |
smyrman
previously approved these changes
Nov 29, 2018
Dragomir-Ivanov
force-pushed
the
master
branch
from
a5f7453
to
f56d27d
Compare
|
Conflict resolved. |
smyrman
reviewed
Nov 30, 2018
Dragomir-Ivanov
force-pushed
the
master
branch
from
4602439
to
8422b43
Compare
|
@smyrman Will do final squash when approved. |
smyrman
reviewed
Nov 30, 2018
Dragomir-Ivanov
force-pushed
the
master
branch
from
8422b43
to
da104d8
Compare
smyrman
approved these changes
Nov 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.