Skip to content

readme breaks prod #1

Merged
merged 1 commit into from Aug 5, 2011

2 participants

@spraints
spraints commented Aug 2, 2011

So, I was trying out honey_badger, and it occurred to me that it would make the app break in production. To simulate, I got the badge working in dev, then updated the Gemfile from

gem 'honey_badger', :group => [ :development, :qa, :beta ]

to

gem 'honey_badger', :group => [ :qa, :beta ]

and there was an error because the honey_badger helper wasn't defined anymore. Also, sprockets couldn't compile the css because honey_badger wasn't in the asset path, either.

So, I changed the readme to recommend including honey_badger in the default bundle, and having the layout decide whether to apply the badge.

There may be a better way to do this, which would be awesome. Also, it might be nice to make the badge still show up in the markup, but have the style hide it in production. Regardless, this seemed like the attached commit is a good change.

@rsanheim rsanheim merged commit 17bca59 into rsanheim:master Aug 5, 2011
@rsanheim
Owner
rsanheim commented Aug 5, 2011

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.