Skip to content

Loading…

fix style definition #2

Merged
merged 1 commit into from

3 participants

@ursm
  • three classes are should specify to a same element.
  • increase z-index (for improving combination with Twitter Bootstrap).
@ursm ursm fixed style definition.
- three classes are should specify to a same element.
- increase z-index (for improving combination with Twitter Bootstrap).
c4a81a7
@rsanheim rsanheim commented on the diff
app/assets/stylesheets/honey_badger.css.scss
@@ -21,7 +21,7 @@
box-shadow: rgba(0,0,0, 0.2) 0px 0px 6px;
-moz-box-shadow: rgba(0,0,0, 0.2) 0px 0px 6px;
-webkit-box-shadow: rgba(0,0,0, 0.2) 0px 0px 6px;
- z-index: 1000;
+ z-index: 1035;
@rsanheim Owner
rsanheim added a note

Why not make the z-index 5000 or something similar -- after all, the badge should almost always be the top level element on the page .. ?

@ursm
ursm added a note

Sorry for late reply.
In Twitter Bootstrap, navbar has z-index: 1030 and backdrop has z-index: 1040. This is between them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@rsanheim rsanheim merged commit 99270b2 into rsanheim:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 7, 2012
  1. @ursm

    fixed style definition.

    ursm committed
    - three classes are should specify to a same element.
    - increase z-index (for improving combination with Twitter Bootstrap).
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 2 deletions.
  1. +2 −2 app/assets/stylesheets/honey_badger.css.scss
View
4 app/assets/stylesheets/honey_badger.css.scss
@@ -1,5 +1,5 @@
@mixin corner-banner($color: #333) {
- .corner-banner.honey-badger {
+ &.corner-banner.honey-badger {
position: absolute;
left: -52px;
top: 30px;
@@ -21,7 +21,7 @@
box-shadow: rgba(0,0,0, 0.2) 0px 0px 6px;
-moz-box-shadow: rgba(0,0,0, 0.2) 0px 0px 6px;
-webkit-box-shadow: rgba(0,0,0, 0.2) 0px 0px 6px;
- z-index: 1000;
+ z-index: 1035;
@rsanheim Owner
rsanheim added a note

Why not make the z-index 5000 or something similar -- after all, the badge should almost always be the top level element on the page .. ?

@ursm
ursm added a note

Sorry for late reply.
In Twitter Bootstrap, navbar has z-index: 1030 and backdrop has z-index: 1040. This is between them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
letter-spacing:1px;
font-style:normal;
font-size:8px !important;
Something went wrong with that request. Please try again.