fix style definition #2

Merged
merged 1 commit into from Apr 28, 2012

Conversation

Projects
None yet
3 participants
@ursm
Contributor

ursm commented Feb 7, 2012

  • three classes are should specify to a same element.
  • increase z-index (for improving combination with Twitter Bootstrap).
fixed style definition.
- three classes are should specify to a same element.
- increase z-index (for improving combination with Twitter Bootstrap).
@@ -21,7 +21,7 @@
box-shadow: rgba(0,0,0, 0.2) 0px 0px 6px;
-moz-box-shadow: rgba(0,0,0, 0.2) 0px 0px 6px;
-webkit-box-shadow: rgba(0,0,0, 0.2) 0px 0px 6px;
- z-index: 1000;
+ z-index: 1035;

This comment has been minimized.

@rsanheim

rsanheim Feb 7, 2012

Owner

Why not make the z-index 5000 or something similar -- after all, the badge should almost always be the top level element on the page .. ?

@rsanheim

rsanheim Feb 7, 2012

Owner

Why not make the z-index 5000 or something similar -- after all, the badge should almost always be the top level element on the page .. ?

This comment has been minimized.

@ursm

ursm Feb 24, 2012

Contributor

Sorry for late reply.
In Twitter Bootstrap, navbar has z-index: 1030 and backdrop has z-index: 1040. This is between them.

@ursm

ursm Feb 24, 2012

Contributor

Sorry for late reply.
In Twitter Bootstrap, navbar has z-index: 1030 and backdrop has z-index: 1040. This is between them.

@hibariya

This comment has been minimized.

Show comment
Hide comment
@hibariya

hibariya Apr 27, 2012

+1

+1

rsanheim added a commit that referenced this pull request Apr 28, 2012

Merge pull request #2 from ursm/patch-1
fix style definition :

make it compatible easily with Twitter Bootstrap

@rsanheim rsanheim merged commit 99270b2 into rsanheim:master Apr 28, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment