From 544aa2c46f28bed8dcf96292a6eab211f5292de6 Mon Sep 17 00:00:00 2001 From: Julia Rechkunova Date: Thu, 23 May 2024 08:40:34 +0200 Subject: [PATCH] [Discover] Unskip ES|QL Inspector tests (#183894) - Closes https://github.com/elastic/kibana/issues/183847 --- .../apps/discover/group4/_esql_view.ts | 23 ++++++++++++++----- .../common/discover/esql/_esql_view.ts | 20 ++++++++++++---- 2 files changed, 33 insertions(+), 10 deletions(-) diff --git a/test/functional/apps/discover/group4/_esql_view.ts b/test/functional/apps/discover/group4/_esql_view.ts index a5a626b8fe77170..a1cecdbc36d4cc1 100644 --- a/test/functional/apps/discover/group4/_esql_view.ts +++ b/test/functional/apps/discover/group4/_esql_view.ts @@ -257,21 +257,32 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { }); }); - // FLAKY: https://github.com/elastic/kibana/issues/183847 - describe.skip('inspector', () => { + describe('inspector', () => { beforeEach(async () => { await PageObjects.common.navigateToApp('discover'); await PageObjects.timePicker.setDefaultAbsoluteRange(); + await PageObjects.header.waitUntilLoadingHasFinished(); + await PageObjects.discover.waitUntilSearchingHasFinished(); }); it('shows Discover and Lens requests in Inspector', async () => { await PageObjects.discover.selectTextBaseLang(); await PageObjects.header.waitUntilLoadingHasFinished(); await PageObjects.discover.waitUntilSearchingHasFinished(); - await inspector.open(); - const requestNames = await inspector.getRequestNames(); - expect(requestNames).to.contain('Table'); - expect(requestNames).to.contain('Visualization'); + let retries = 0; + await retry.try(async () => { + if (retries > 0) { + await inspector.close(); + await testSubjects.click('querySubmitButton'); + await PageObjects.header.waitUntilLoadingHasFinished(); + await PageObjects.discover.waitUntilSearchingHasFinished(); + } + await inspector.open(); + retries = retries + 1; + const requestNames = await inspector.getRequestNames(); + expect(requestNames).to.contain('Table'); + expect(requestNames).to.contain('Visualization'); + }); }); }); diff --git a/x-pack/test_serverless/functional/test_suites/common/discover/esql/_esql_view.ts b/x-pack/test_serverless/functional/test_suites/common/discover/esql/_esql_view.ts index 7445596a7175fa5..29bbc4b3c3e9cb0 100644 --- a/x-pack/test_serverless/functional/test_suites/common/discover/esql/_esql_view.ts +++ b/x-pack/test_serverless/functional/test_suites/common/discover/esql/_esql_view.ts @@ -261,16 +261,28 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { beforeEach(async () => { await PageObjects.common.navigateToApp('discover'); await PageObjects.timePicker.setDefaultAbsoluteRange(); + await PageObjects.header.waitUntilLoadingHasFinished(); + await PageObjects.discover.waitUntilSearchingHasFinished(); }); it('shows Discover and Lens requests in Inspector', async () => { await PageObjects.discover.selectTextBaseLang(); await PageObjects.header.waitUntilLoadingHasFinished(); await PageObjects.discover.waitUntilSearchingHasFinished(); - await inspector.open(); - const requestNames = await inspector.getRequestNames(); - expect(requestNames).to.contain('Table'); - expect(requestNames).to.contain('Visualization'); + let retries = 0; + await retry.try(async () => { + if (retries > 0) { + await inspector.close(); + await testSubjects.click('querySubmitButton'); + await PageObjects.header.waitUntilLoadingHasFinished(); + await PageObjects.discover.waitUntilSearchingHasFinished(); + } + await inspector.open(); + retries = retries + 1; + const requestNames = await inspector.getRequestNames(); + expect(requestNames).to.contain('Table'); + expect(requestNames).to.contain('Visualization'); + }); }); });