Permalink
Commits on Aug 23, 2018
  1. Merge pull request #1763 from jlahtinen/simple_error_when_invalid_dat…

    yahonda committed Aug 23, 2018
    …abase_configuration
    
    Do not set nil value to java.util.Properties
  2. Merge pull request #1762 from jlahtinen/remove_native_exception_rails6

    yahonda committed Aug 23, 2018
    Remove NativeException
  3. Do not set nil value to java.util.Properties

    Joni Lahtinen
    Joni Lahtinen committed Aug 23, 2018
  4. Remove NativeException

    Joni Lahtinen
    Joni Lahtinen committed Aug 23, 2018
Commits on Aug 19, 2018
  1. Merge pull request #1759 from yahonda/enable_parentheses_around_condi…

    koic committed Aug 19, 2018
    …tion_cop
    
    Enable Style/ParenthesesAroundCondition cop
  2. Enable Style/ParenthesesAroundCondition cop

    yahonda committed Aug 19, 2018
Commits on Aug 17, 2018
  1. Merge pull request #1758 from yahonda/lint_uri_escape_unescape

    yahonda committed Aug 17, 2018
    Enable `Lint/UriEscapeUnescape` cop
  2. Enable `Lint/UriEscapeUnescape` cop

    yahonda committed Aug 17, 2018
Commits on Aug 7, 2018
  1. Merge pull request #1751 from yahonda/add_history_v523

    yahonda committed Aug 7, 2018
    Prepare release v5.2.3 [skip ci]
  2. Merge pull request #1744 from yahonda/restore_column_cache

    yahonda committed Aug 7, 2018
    Introduce column cache per connection
  3. Introduce column cache per connection

    yahonda committed Jul 23, 2018
    rsim/oracle-enhanced#1490 removed Oracle enhanced adapter own column cache feature
    to use Rails `db:schema:cache:dump`.  However, it caused slower performance
    about metadata search, such as column information.
    
    This commit restores Oracle enhanced adapter own column cache feature.
    It used to be class level caching, it is connection level caching now
    since it is much easier and cleaner than class level ones.
    
    Related to rsim/oracle-enhanced#1720
Commits on Aug 6, 2018
  1. Merge pull request #1747 from yahonda/add_another_condition_to_indexes

    yahonda committed Aug 6, 2018
    Add table_name search condition to `indexes(table_name)` method
  2. Add table_name search condition to `indexes(table_name)` method

    yahonda committed Aug 2, 2018
    and restored one spec which has been removed at #1672
    
    Related to #1720
Commits on Aug 2, 2018
  1. Merge pull request #1745 from yahonda/use_cursor_sharing_force

    yahonda committed Aug 2, 2018
    Use cursor_sharing = force by default again
  2. Use cursor_sharing = force by default again

    yahonda committed Jul 23, 2018
    it actually reverts #1503
    
    rsim/oracle-enhanced#1498 implemented prepared statements for dictionary
    queries. However #1713 restored non-prepared statements
    for `column_definitions` and `pk_and_sequence_for`, which likely have caused
    longer elapsed time for these queries reported at #1720
    
    Those who needs 'cursor_sharing = exact' can specify its own value to .database.yml
Commits on Aug 1, 2018
  1. Merge pull request #1742 from koic/suppress_warning_bigdecimal_new

    yahonda committed Aug 1, 2018
    Suppress warning `BigDecimal.new` is deprecated
Commits on Jul 30, 2018
  1. Suppress warning `BigDecimal.new` is deprecated

    koic committed Jul 30, 2018
    Follow up of rails/rails#31435.
    
    This PR suppresses the following warning.
    
    ```console
    % bundle exec rspec
    
    (snip)
    
    /home/travis/build/rsim/oracle-enhanced/lib/active_record/connection_adapters/oracle_enhanced/jdbc_connection.rb:484:
    warning: BigDecimal.new is deprecated
    ```
    
    https://travis-ci.org/rsim/oracle-enhanced/jobs/409700715#L775
    
    This is a warning found in JRuby, but this commit has made same
    changes to MRI (OCI connection) .
  2. Merge pull request #1739 from yahonda/ignore_jruby_head_error

    yahonda committed Jul 30, 2018
    Add allow_railures for jruby-head until #1737 resolved
  3. Merge pull request #1738 from yahonda/rails32695

    koic committed Jul 30, 2018
    Introduced StartWith, EndWith and RegexpMatch cops
  4. Add allow_railures for jruby-head until #1737 resolved

    yahonda committed Jul 30, 2018
  5. Introduced StartWith, EndWith and RegexpMatch cops

    yahonda committed Jul 30, 2018
Commits on Jul 27, 2018
  1. Merge pull request #1736 from koic/use_rubocop_0_58_channel

    yahonda committed Jul 27, 2018
    Use `rubocop-0-58` channel
  2. Use `rubocop-0-58` channel

    koic committed Jul 27, 2018
    Follow up of rails/rails#33278.
Commits on Jul 26, 2018
  1. Merge pull request #1734 from koic/tern_on_performance_based_cops

    yahonda committed Jul 26, 2018
    Turn on performance based cops
  2. Turn on performance based cops

    koic committed Jul 26, 2018
    Follow up of rails/rails#32381.
    
    In addition, this PR applies the following auto-correct.
    
    ```console
    % rubocop -a
    Inspecting 64 files
    ..........C.....................................................
    
    Offenses:
    
    spec/active_record/connection_adapters/oracle_enhanced/schema_dumper_spec.rb:22:5:
    C: [Corrected] Performance/RedundantMerge: Use options[:force] = true
    instead of options.merge! force: true.
        options.merge! force: true
        ^^^^^^^^^^^^^^^^^^^^^^^^^^
    
    64 files inspected, 1 offense detected, 1 offense corrected
    ```
Commits on Jul 12, 2018
  1. Merge pull request #1732 from koic/enable_empty_lines_around_block_body

    koic committed Jul 12, 2018
    Enable `Layout/EmptyLinesAroundBlockBody` cop
  2. Enable `Layout/EmptyLinesAroundBlockBody` cop

    koic committed Jul 12, 2018
    Follow up of rails/rails#33350.
Commits on May 25, 2018
  1. Merge pull request #1728 from yahonda/ci_jruby9200

    yahonda committed May 25, 2018
    CI against JRuby 9.2.0.0
Commits on May 24, 2018
  1. CI against JRuby 9.2.0.0

    yahonda committed May 24, 2018
Commits on May 22, 2018
  1. Merge pull request #1725 from yahonda/remove_gem_install_bundler

    yahonda committed May 22, 2018
    Do not install bundler explicitly
  2. Merge pull request #1724 from koic/enable_string_conversion_in_interp…

    koic committed May 22, 2018
    …olation
    
    Enable `Lint/StringConversionInInterpolation` cop
  3. Enable `Lint/StringConversionInInterpolation` cop

    koic committed May 22, 2018
    Follow up of rails/rails@a77447f.
Commits on Apr 27, 2018
  1. Merge pull request #1718 from yahonda/add_history_v522

    yahonda committed Apr 27, 2018
    Prepare release v5.2.2 [skip ci]