Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Support reset_pk_sequence! #283

Closed
yahonda opened this Issue · 3 comments

2 participants

@yahonda
Collaborator

To address the issue reported in rails/rails#7334 Oracle enhanced adapter can support reset_pk_sequence! as postgresql adapter does.

https://github.com/rails/rails/blob/master/activerecord/lib/active_record/fixtures.rb#L487-L491

https://github.com/rails/rails/blob/master/activerecord/lib/active_record/connection_adapters/postgresql/schema_statements.rb#L240

I'm working on this, Will open a pull request soon.

@ebeigarts
Collaborator

Didn't you already implement this in #83 ?

@yahonda
Collaborator

Right. You remember this old pull request :smile: I've implemented similar feature reset_sequence! in #83. I'm working on reset_pk_sequence! based on this, and found it needs some rework, such as supporting table_name argument sometimes Symbol or something.

@yahonda
Collaborator

Closed #287.

@yahonda yahonda closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.