Bug when NUMERIC type has a SCALE of nil #165

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants

CoryFoy commented Apr 27, 2012

This commit fixes an issue where we have a NUMERIC column with a SCALE of nil that was being considered a BigDecimal instead of an integer

CoryFoy commented Apr 27, 2012

I'm working on providing a test case too - I couldn't get bundler to install the gems for some reason. Will get that soon.

Owner

rsim commented Apr 28, 2012

Yes, please add test case as I try to have test coverage for all edge cases.

CoryFoy commented May 1, 2012

I can't actually add any test cases - I'm on Lion, so there's no support for Oracle. Also, I had to modify the Gemfile to get bundle to install (see rails/rails#6039). However, both of these commits were production bugs which were fixed with the above code. I'd be happy to share more details if you'd like.

Collaborator

yahonda commented Nov 18, 2012

If it is still an issue, please update your pull request with necessary tests.
Tests make sure what your code fix and also it prevents from future regressions by other changes.

There are some info how to install ruby-oci8 on Lion. ( I'm not using Oracle client with Mac, I do not have any answer how to install ruby-oci8/Oracle client on Lion, though). Or installing VirtualBox on your Mac and you can run any Linux(CentOS, Oracle Linux).

rails/rails#6039 issus has been resolved, bundler should work.

Collaborator

yahonda commented Jun 19, 2015

Closing since it has not been updated recently.

yahonda closed this Jun 19, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment