This commit fixes an issue where we have a NUMERIC column with a SCALE of nil that was being considered a BigDecimal instead of an integer
Fixed bug where a numeric column has scale as nil but being considere…
I'm working on providing a test case too - I couldn't get bundler to install the gems for some reason. Will get that soon.
Yes, please add test case as I try to have test coverage for all edge cases.
Fixed if the primary_key is defined as a symbol it won't find it for …
…certain types of updates
I can't actually add any test cases - I'm on Lion, so there's no support for Oracle. Also, I had to modify the Gemfile to get bundle to install (see rails/rails#6039). However, both of these commits were production bugs which were fixed with the above code. I'd be happy to share more details if you'd like.
If it is still an issue, please update your pull request with necessary tests.
Tests make sure what your code fix and also it prevents from future regressions by other changes.
There are some info how to install ruby-oci8 on Lion. ( I'm not using Oracle client with Mac, I do not have any answer how to install ruby-oci8/Oracle client on Lion, though). Or installing VirtualBox on your Mac and you can run any Linux(CentOS, Oracle Linux).
rails/rails#6039 issus has been resolved, bundler should work.
Closing since it has not been updated recently.