From 9bc5a01bf2fe6d6994fa967b5dbdae19a5264a93 Mon Sep 17 00:00:00 2001 From: Koichi ITO Date: Tue, 27 Mar 2018 15:35:56 +0900 Subject: [PATCH] Remove db link codes Follow up of #1668. This PR removes the codes that seems to have forgotten to remove in the above. --- .../oracle_enhanced/schema_statements.rb | 2 +- .../oracle_enhanced/schema_statements_spec.rb | 8 +------- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/lib/active_record/connection_adapters/oracle_enhanced/schema_statements.rb b/lib/active_record/connection_adapters/oracle_enhanced/schema_statements.rb index da9762c32..d9ecd71af 100644 --- a/lib/active_record/connection_adapters/oracle_enhanced/schema_statements.rb +++ b/lib/active_record/connection_adapters/oracle_enhanced/schema_statements.rb @@ -365,7 +365,7 @@ def rename_index(table_name, old_name, new_name) #:nodoc: # # add_synonym :posts, "blog.posts" # add_synonym :posts_seq, "blog.posts_seq" - # add_synonym :employees, "hr.employees@dblink", :force => true + # add_synonym :employees, "hr.employees", :force => true # def add_synonym(name, table_name, options = {}) sql = "CREATE".dup diff --git a/spec/active_record/connection_adapters/oracle_enhanced/schema_statements_spec.rb b/spec/active_record/connection_adapters/oracle_enhanced/schema_statements_spec.rb index fd89e5e2e..458d5849d 100644 --- a/spec/active_record/connection_adapters/oracle_enhanced/schema_statements_spec.rb +++ b/spec/active_record/connection_adapters/oracle_enhanced/schema_statements_spec.rb @@ -779,12 +779,7 @@ class ::TestComment < ActiveRecord::Base describe "synonyms" do before(:all) do @conn = ActiveRecord::Base.connection - @db_link = "db_link" - @username = @db_link_username = CONNECTION_PARAMS[:username] - @db_link_password = CONNECTION_PARAMS[:password] - @db_link_database = CONNECTION_PARAMS[:database] - @conn.execute "DROP DATABASE LINK #{@db_link}" rescue nil - @conn.execute "CREATE DATABASE LINK #{@db_link} CONNECT TO #{@db_link_username} IDENTIFIED BY \"#{@db_link_password}\" USING '#{@db_link_database}'" + @username = CONNECTION_PARAMS[:username] schema_define do create_table :test_posts, force: true do |t| t.string :title @@ -796,7 +791,6 @@ class ::TestComment < ActiveRecord::Base schema_define do drop_table :test_posts end - @conn.execute "DROP DATABASE LINK #{@db_link}" rescue nil end before(:each) do