Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error when writing lobs #1962

Merged
merged 1 commit into from Dec 18, 2019
Merged

Conversation

@koic
Copy link
Collaborator

koic commented Dec 18, 2019

Summary

Fixes #1932.

This PR fixes an error when writing lobs.
This error seems to be caused by #1546. Rails 5.2 and 6.0 has been targeted.

Other Information

#1932 discusses backporting to Rails 5.2 and Rails 6.0.

### Summary

Fixes #1932.

This PR fixes an error when writing lobs.
This error seems to be caused by #1546. Rails 5.2 and 6.0 has been targeted.

### Other Information

#1932 discusses backporting to Rails 5.2 and Rails 6.0.
@koic

This comment has been minimized.

Copy link
Collaborator Author

koic commented Dec 18, 2019

@yahonda If you are good about this PR, I'd like to backport this patch. Please tell me your planning when it's convenient for you.

@yahonda yahonda merged commit becf833 into rsim:master Dec 18, 2019
2 checks passed
2 checks passed
build
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@koic koic deleted the koic:fix_an_error_when_writing_lobs branch Dec 18, 2019
yahonda added a commit to yahonda/oracle-enhanced that referenced this pull request Dec 18, 2019
Fix an error when writing lobs
yahonda added a commit to yahonda/oracle-enhanced that referenced this pull request Dec 18, 2019
Updated manually because there is a git conflict to backport rsim#1962 to release52.
@yahonda

This comment has been minimized.

Copy link
Collaborator

yahonda commented Dec 18, 2019

I have opened backport pull requests to release60 and release52 branch.
Let me release new versions of Oracle enhanced adapter like 6.0.1 and 5.2.7.

koic added a commit that referenced this pull request Dec 19, 2019
Backport #1962 to release60 branch
yahonda added a commit to yahonda/oracle-enhanced that referenced this pull request Dec 19, 2019
Updated manually because there is a git conflict to backport rsim#1962 to release52.
koic added a commit that referenced this pull request Dec 19, 2019
Backport #1962 to release52 branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.