Address test create table with defaults #384

merged 2 commits into from Dec 2, 2013


None yet

1 participant

yahonda commented Dec 2, 2013

This pull request address the following failure when tested with rails master branch by moving add_column_options! into SchemaCreation class.

To support Rails 4.0 options_include_default! method added, which can be removed Oracle enhanced adapter supports only Rails 4.1 and upper version of Rails.

$ ARCONN=oracle ruby -Itest test/cases/migration/change_schema_test.rb -n test_create_table_with_defaults
Using oracle
Run options: -n test_create_table_with_defaults --seed 18272

# Running:


Finished in 0.082692s, 12.0931 runs/s, 60.4656 assertions/s.

  1) Failure:
ActiveRecord::Migration::ChangeSchemaTest#test_create_table_with_defaults [test/cases/migration/change_schema_test.rb:74]:
Expected: "hello"
  Actual: nil

1 runs, 5 assertions, 1 failures, 0 errors, 0 skips
@yahonda yahonda merged commit eaf8e92 into rsim:master Dec 2, 2013
yahonda commented Dec 3, 2013
@yahonda yahonda deleted the yahonda:address_test_create_table_with_defaults branch Dec 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment