Fast Bridge Alternative #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guidohernan93
force-pushed
the
fast-bridge-alternative
branch
6 times, most recently
from
2f1c06f
to
a525bec
Compare
SergioDemianLerner
requested changes
Oct 6, 2020
guidohernan93
force-pushed
the
fast-bridge-alternative
branch
2 times, most recently
from
4327559
to
f6a4f74
Compare
guidohernan93
force-pushed
the
fast-bridge-alternative
branch
from
f6a4f74
to
a0dcfe6
Compare
guidohernan93
force-pushed
the
fast-bridge-alternative
branch
2 times, most recently
from
dc73ea8
to
0b739f3
Compare
josedahlquist
force-pushed
the
fast-bridge-alternative
branch
2 times, most recently
from
2a2eb29
to
ccd9935
Compare
josedahlquist
force-pushed
the
fast-bridge-alternative
branch
from
ccd9935
to
e030f5e
Compare
smishraIOV
reviewed
Jul 15, 2021
smishraIOV
reviewed
Jul 15, 2021
smishraIOV
reviewed
Jul 15, 2021
smishraIOV
reviewed
Jul 15, 2021
smishraIOV
reviewed
Jul 15, 2021
smishraIOV
approved these changes
Jul 15, 2021
SergioDemianLerner
previously requested changes
Jul 16, 2021
IPs/RSKIP176.md
Outdated
| ## Previous concepts | ||
|
|
||
| #####Derived Federation | ||
| The derived federation is the result of a process that will be carried out by creating a 32 bytes hash built from some provided derivation arguments and the active federation redeem script. The derivation arguments are values used to close the agreement between the Liquidity Provider and the user. |
There was a problem hiding this comment.
Suggested rewording:
The derived Powpeg address results from a transformation of the active Powpeg redeem script and a 32 bytes hash of some arguments related to that specific peg-in operation .The arguments are agreed by a Liquidity Provider and a user who wishes to peg-in.
IPs/RSKIP176.md
Outdated
|
|
||
| **Derivation Arguments** | ||
|
|
||
| The derivation arguments are values used to close the agreement between the Liquidity Provider and the user. Some of these parameters are the RSK address where funds will be received, the BTC refund address, the Liquidity Bridge Contract address, the value to transfer, the amount of BTC blocks that the Liquidity Provider should wait before advancing the funds, the Liquidity Provider BTC refund address, the derived Federation address, and some other values that are domain of the Liquidity Provider. |
There was a problem hiding this comment.
First you call them arguments, but then "parameters". Let's stick to "arguments"
bguiz
reviewed
Oct 25, 2021
Co-authored-by: Brendan Graetz <bguiz@users.noreply.github.com>
bguiz
approved these changes
Oct 26, 2021
josedahlquist
approved these changes
Oct 26, 2021
josedahlquist
dismissed
SergioDemianLerner’s stale review
Sergio rewrote the RSKIP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.