New minimum values for peg-in and peg-out operations in the 2wp #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamgonzalez
force-pushed
the
peg-in-peg-out-set-minimums
branch
from
afa7efa
to
c097b04
Compare
marcos-iov
force-pushed
the
peg-in-peg-out-set-minimums
branch
2 times, most recently
from
86a2521
to
7fb3098
Compare
marcos-iov
changed the title
Co-authored-by: josedahlquist <jose.dahlquist@gmail.com>
marcos-iov
force-pushed
the
peg-in-peg-out-set-minimums
branch
from
80c6c5a
to
4c29aa5
Compare
josedahlquist
approved these changes
Jul 13, 2021
smishraIOV
reviewed
Jul 15, 2021
smishraIOV
reviewed
Jul 15, 2021
smishraIOV
reviewed
Jul 15, 2021
IPs/RSKIP219.md
Outdated
|
|
||
| After this RSKIP activation, the minimum value accepted to perform a peg-out is **0.004 RBTC**. If less than this amount is sent to the bridge address then those funds will be refunded to the user. | ||
| Additionally, a calculation of the fees to be paid by the user is made. If after subtracting the fees, the amount to be received by the user is less than the configured percentage of the total value trying to peg-out then the peg-out will not be completed and funds will be returned to the user. | ||
| The percentage is established on each network independently. The suggested value is 80%. |
There was a problem hiding this comment.
- not sure what "each network" means
- what does "suggested value" mean? Is it a default threshold that a user must explicitly override?
There was a problem hiding this comment.
Each network -> regtest, testnet, mainnet
The value is defined in a constants file in rskj code, there is a different file for each network. It's currently set to %80 in mainnet
There was a problem hiding this comment.
At the current state of this RSKIP "suggested" should be replaced by the exact values that have been chosen for consensus for the different networks.
smishraIOV
reviewed
Jul 15, 2021
smishraIOV
approved these changes
Jul 15, 2021
SergioDemianLerner
requested changes
Jul 16, 2021
IPs/RSKIP219.md
Outdated
|
|
||
| After this RSKIP activation, the minimum value accepted to perform a peg-out is **0.004 RBTC**. If less than this amount is sent to the bridge address then those funds will be refunded to the user. | ||
| Additionally, a calculation of the fees to be paid by the user is made. If after subtracting the fees, the amount to be received by the user is less than the configured percentage of the total value trying to peg-out then the peg-out will not be completed and funds will be returned to the user. | ||
| The percentage is established on each network independently. The suggested value is 80%. |
There was a problem hiding this comment.
At the current state of this RSKIP "suggested" should be replaced by the exact values that have been chosen for consensus for the different networks.
josedahlquist
approved these changes
Aug 23, 2021
SergioDemianLerner
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New minimum values for peg-in and peg-out operations in the 2wp