New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup rsk config properties #643

Merged
merged 1 commit into from Sep 12, 2018

Conversation

Projects
None yet
3 participants
@lsebrie
Contributor

lsebrie commented Sep 10, 2018

  • removed when not needed
  • tidy up properties and values handled inside class
@tinchou

Looks good! If you want, move default values to reference.conf for extra points.

@lsebrie lsebrie force-pushed the remove_config_rskmessage branch 3 times, most recently from 07a737d to 7ac8367 Sep 10, 2018

Cleanup rsk config properties
- removed when not needed
- tidy up properties and values handled inside class

@lsebrie lsebrie force-pushed the remove_config_rskmessage branch from 7ac8367 to 003d9f0 Sep 12, 2018

@tinchou

Good to go

@aeidelman aeidelman merged commit 96bba53 into master Sep 12, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
default Build finished.
Details
sonarqube SonarQube reported no issues

@aeidelman aeidelman deleted the remove_config_rskmessage branch Sep 12, 2018

@aeidelman aeidelman added this to the Orchid v0.5.1 milestone Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment