New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge branches storage #653

Merged
merged 3 commits into from Oct 2, 2018

Conversation

Projects
None yet
4 participants
@diega
Contributor

diega commented Sep 28, 2018

No description provided.

@diega diega force-pushed the picco_forever branch from 3fecce8 to 4eb8d3c Sep 28, 2018

details.keys = new HashSet<>();
details.keys.addAll(this.keys);
details.externalStorage = this.externalStorage;
details.originalExternalStorage = this.originalExternalStorage;
if (this.externalStorage) {
levelDbByName(getDataSourceName(), databaseDir);
DataSourcePool.reserve(getDataSourceName());

This comment has been minimized.

@SergioDemianLerner

SergioDemianLerner Sep 28, 2018

Contributor

Pregunta: porque el cambio de levelDBByName*( a DataSourcePool.reserve(). Cual es la diferencia?

@@ -401,7 +407,7 @@ private void removeKey(byte[] key) {
}
private void checkExternalStorage() {
this.externalStorage = (keys.size() > memoryStorageLimit) || this.externalStorage;
this.externalStorage = true;

This comment has been minimized.

@SergioDemianLerner

SergioDemianLerner Sep 28, 2018

Contributor

Porque decidieron no usar mas el encoding liviano ?

updateContractDetails(addr, contractDetails);
updateContractDetails(addr, contractDetails, storeContractDetails);

This comment has been minimized.

@SergioDemianLerner

SergioDemianLerner Sep 28, 2018

Contributor

Como justificarían que este es el único lugar posible donde es necesario hacer el merge ?

Split building methods for using outside Spring Beans
Co-authored-by: Lisandro Sebrie <lisandro@rsk.co>

@diega diega force-pushed the picco_forever branch from 4eb8d3c to a031cb6 Sep 30, 2018

@lsebrie lsebrie force-pushed the picco_forever branch from a031cb6 to 8328fc8 Oct 1, 2018

diega and others added some commits Sep 26, 2018

Extract TrieStore Factory
Co-authored-by: Lisandro Sebrie <lisandro@rsk.co>
Always save ContractDetails trie to external storage
Co-authored-by: Lisandro Sebrie <lisandro@rsk.co>

@lsebrie lsebrie force-pushed the picco_forever branch from 8328fc8 to 2974626 Oct 1, 2018

@rskops

This comment has been minimized.

rskops commented Oct 1, 2018

SonarQube analysis reported 1 issue

  1. MAJOR DefaultConfig.java#L75: java/io/File.(Ljava/lang/String;)V reads a file whose location might be specified by user input rule

@aeidelman aeidelman merged commit 1e97bea into master Oct 2, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
default Build finished.
Details
sonarqube SonarQube reported 1 issue, no criticals or blockers

@aeidelman aeidelman deleted the picco_forever branch Oct 2, 2018

@aeidelman aeidelman added this to the Orchid v0.5.1 milestone Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment