New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't close UDP channel on exception #670

Merged
merged 1 commit into from Oct 19, 2018

Conversation

Projects
None yet
4 participants
@tinchou
Contributor

tinchou commented Oct 18, 2018

We don't need to close the channel because UDP is connection-less.

There was a comment stating this, but someone ignored it at some point
in the EthereumJ codebase: ethereum/ethereumj@65fd770#diff-364a0e29f783aa2c9c709bc8ae663b9dR60

@tinchou tinchou requested a review from juli Oct 18, 2018

@tinchou tinchou force-pushed the udp_close branch from 3e9d78e to 4af0250 Oct 19, 2018

@lsebrie lsebrie added this to the Orchid v0.5.3 milestone Oct 19, 2018

Don't close UDP channel on exception
We don't need to close the channel because UDP is connection-less.

There was a comment stating this, but someone ignored it at some point
in the EthereumJ codebase: ethereum/ethereumj@65fd770#diff-364a0e29f783aa2c9c709bc8ae663b9dR60

@tinchou tinchou force-pushed the udp_close branch from 4af0250 to f34374d Oct 19, 2018

@diega

diega approved these changes Oct 19, 2018

@aeidelman aeidelman merged commit 90fd8ee into master Oct 19, 2018

2 of 3 checks passed

default Build triggered for merge commit.
Details
ci/circleci Your tests passed on CircleCI!
Details
sonarqube SonarQube reported no issues

@aeidelman aeidelman deleted the udp_close branch Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment