New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify contracts tries #692

Merged
merged 10 commits into from Nov 8, 2018

Conversation

Projects
None yet
4 participants
@diega
Contributor

diega commented Nov 8, 2018

No description provided.

ajlopez added some commits Oct 29, 2018

@diega diega force-pushed the new_onestoragex branch from 62130d3 to 23fdbc0 Nov 8, 2018

@rskops

This comment has been minimized.

rskops commented Nov 8, 2018

SonarQube analysis reported 17 issues

  • CRITICAL 3 critical
  • MAJOR 7 major
  • MINOR 3 minor
  • INFO 4 info

Top 10 issues

  1. CRITICAL ContractDetailsImpl.java#L49: Remove this unused "panicProcessor" private field. rule
  2. CRITICAL CommonConfig.java#L44: Unused import - org.ethereum.datasource.DataSourcePool.levelDbByName. rule
  3. CRITICAL DataSourcePool.java#L24: Unused import - java.io.File. rule
  4. MAJOR ContractDetailsImpl.java#L191: Remove this unused "rlpIsExternalStorage" local variable. rule
  5. MAJOR ContractDetailsImpl.java#L191: Remove this useless assignment to local variable "rlpIsExternalStorage". rule
  6. MAJOR ContractDetailsImpl.java#L357: Inconsistent synchronization of co.rsk.db.ContractDetailsImpl.keys; locked 60% of time rule
  7. MAJOR ContractDetailsImpl.java#L382: Remove this method and declare a constant for this value. rule
  8. MAJOR ContractStorageStoreFactory.java#L55: Remove this method and declare a constant for this value. rule
  9. MAJOR LevelDbDataSource.java#L116: java/nio/file/Paths.get(Ljava/lang/String;[Ljava/lang/String;)Ljava/nio/file/Path; reads a file whose location might be specified by user input rule
  10. MAJOR LevelDbDataSource.java#L118: java/nio/file/Paths.get(Ljava/lang/String;[Ljava/lang/String;)Ljava/nio/file/Path; reads a file whose location might be specified by user input rule
@aeidelman

Approved

@aeidelman aeidelman merged commit 2ee9026 into master Nov 8, 2018

2 of 3 checks passed

sonarqube SonarQube reported 17 issues, with 3 critical
ci/circleci Your tests passed on CircleCI!
Details
default Build finished.
Details

@aeidelman aeidelman deleted the new_onestoragex branch Nov 8, 2018

@aeidelman aeidelman added this to the Orchid v0.5.3 milestone Nov 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment