Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrieKeySlice abstraction #778

Merged
merged 2 commits into from Mar 7, 2019

Conversation

Projects
None yet
4 participants
@tinchou
Copy link
Contributor

commented Mar 7, 2019

Inspired by the ExpandedKey abstraction from the unitrie branch, we create TrieKeySlice.

It basically groups some related data and behavior to manipulate shared paths in a trie.

@tinchou tinchou added the unitrie label Mar 7, 2019

@tinchou tinchou force-pushed the triekeyslice branch 2 times, most recently from 3952d66 to 2f345de Mar 7, 2019

@tinchou tinchou force-pushed the triekeyslice branch from 2f345de to 161e664 Mar 7, 2019

@rskops

This comment has been minimized.

Copy link

commented Mar 7, 2019

SonarQube analysis reported 4 issues

  1. MAJOR TrieImpl.java#L806: Method co.rsk.trie.TrieImpl.split(TrieKeySlice) appears to call the same method on the same object redundantly rule
  2. MINOR TrieKeySlice.java#L32: Store a copy of "expandedKey". rule
  3. INFO TrieKeySlice.java#L46: Complete the task associated to this TODO comment. rule
  4. INFO TrieKeySlice.java#L105: Complete the task associated to this TODO comment. rule
@lsebrie

lsebrie approved these changes Mar 7, 2019

Copy link
Contributor

left a comment

LGTM

@lsebrie lsebrie merged commit a448fb0 into master Mar 7, 2019

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
default Build finished.
Details
sonarqube SonarQube reported 4 issues, no criticals or blockers

@lsebrie lsebrie deleted the triekeyslice branch Mar 7, 2019

@aeidelman aeidelman added this to the Orchid v0.6.2 milestone Apr 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.