Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up trie interface #783

Merged
merged 3 commits into from Mar 15, 2019

Conversation

Projects
None yet
4 participants
@tinchou
Copy link
Contributor

commented Mar 14, 2019

  • merges Trie with TrieImpl
  • replaces withSecure with a constructor parameter

@tinchou tinchou added the unitrie label Mar 14, 2019

@tinchou tinchou requested a review from lsebrie Mar 14, 2019

@rskops

This comment has been minimized.

Copy link

commented Mar 14, 2019

SonarQube analysis reported 14 issues

  • MAJOR 6 major
  • MINOR 6 minor
  • INFO 2 info

Top 10 issues

  1. MAJOR Trie.java#L134: The Cyclomatic Complexity of this method "fromMessage" is 11 which is greater than 10 authorized. rule
  2. MAJOR Trie.java#L450: Return an empty array instead of null. rule
  3. MAJOR Trie.java#L455: Return an empty array instead of null. rule
  4. MAJOR Trie.java#L464: Return an empty array instead of null. rule
  5. MAJOR Trie.java#L709: Return an empty array instead of null. rule
  6. MAJOR GenesisLoader.java#L119: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  7. MINOR Trie.java#L56: Use already-defined constant 'PANIC_TOPIC' instead of duplicating its value here. rule
  8. MINOR Trie.java#L109: Store a copy of "value". rule
  9. MINOR Trie.java#L459: Return a copy of "value". rule
  10. MINOR Trie.java#L684: This block of commented-out lines of code should be removed. rule

@lsebrie lsebrie merged commit 1a16b77 into master Mar 15, 2019

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
default Build finished.
Details
sonarqube SonarQube reported 14 issues, no criticals or blockers

@aeidelman aeidelman added this to the Orchid v0.6.2 milestone Apr 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.