Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

co.rsk.net.Metrics and its usage removed #786

Merged
merged 3 commits into from Mar 21, 2019

Conversation

Projects
None yet
4 participants
@raullaprida
Copy link
Contributor

commented Mar 19, 2019

co.rsk.net.Metrics and its usage removed since no usage of the generated output has been found.
I encourage the reviewers to confirm there's no other project importing rskj and consuming this Metric class outputs.

@raullaprida raullaprida requested a review from tinchou Mar 19, 2019

@tinchou

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

Please remove the unused acceptedTxs variable, which is now unnecessary (see the Sonar report above).
I would also appreciate if you could remove some of the empty lines at the beginning of the methods you changed!

@raullaprida raullaprida force-pushed the remove_old_metric_logs branch from 280466e to 9e01e21 Mar 20, 2019

@diega
Copy link
Contributor

left a comment

great!

@raullaprida raullaprida force-pushed the remove_old_metric_logs branch from b378b3d to 9e80249 Mar 21, 2019

@raullaprida raullaprida requested a review from diega Mar 21, 2019

@tinchou
Copy link
Contributor

left a comment

image

@diega diega merged commit dfc1c75 into master Mar 21, 2019

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
default Build finished.
Details
sonarqube SonarQube reported no issues

@diega diega deleted the remove_old_metric_logs branch Mar 21, 2019

@aeidelman aeidelman added this to the Orchid v0.6.2 milestone Apr 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.