New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Bridge method ReceiveHeaders public as part of network upgrade R… #865
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except my comment looks good
7db5a68
to
9807538
Compare
9807538
to
260926c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would give a name to the costs defined for gas whenever you can. The PR in general is good only minor changes are asked. I avoided evaluating the actual gas values, I think it's out of scope for this PR
rskj-core/src/test/java/co/rsk/peg/performance/ReceiveHeadersTest.java
Outdated
Show resolved
Hide resolved
079fad0
to
9b85182
Compare
…SKIP124