Php7 compatibility update #16
Conversation
Changes Cli and Analyser to php-parser 2.0 which supports PHP 7 parsing.
I was getting errors when running phpunit and was seeing the following: "Class 'Prophecy\PhpUnit\ProphecyTestCase' not found"
mallardduck
force-pushed
the
php7-update
branch
from
8e26b71 to
2f87788
Compare
Well somehow running with the globally installed phpunit I wasn't seeing errors. running with vendor phpunit and I was seeing errors. First I tried an update to local phpunit, fix a few things and now there's only a single error left in the tests. While I was able to fix the issue I'm far too naiev to how this and php-parser package function to write a proper fix for the test. Also, since I have never used phrophecy with my unit tests, I'm a bit unfamiliar with how to use that correctly.
mallardduck
force-pushed
the
php7-update
branch
from
fcc5952 to
6112c12
Compare
|
@mallardduck Thank you very much for taking the time to submit a pull request! |
| */ | ||
| public function __construct( | ||
| ParserAbstract $parser, | ||
| Multiple $parser, |
There was a problem hiding this comment.
This should hint against the Parser interface, instead of Multiple.
There was a problem hiding this comment.
I don't think that's quite right. From what I'm seeing Cli.php creates the class being passed into this construct here:
private function createParser()
{
$parser = (new ParserFactory)->create(ParserFactory::PREFER_PHP7);
return $parser;
}
Since this results in the creation of an instance of: PhpParser\Parser\Multiple I'm type hinting for that class.
|
Other than requiring PHP 5.6 this patch set seems to be working correctly and is now passing all tests (where possible). I'm unsure where or how this should be merged in as the updates to PHPunit now require a minimum of PHP 5.6. I personally don't think this is a big deal since anything prior is considered End Of Life. |
|
@mallardduck Awesome! The tests are indeed passing, and dropping support for PHP 5.5 is fine since it's indeed EOL. I'll merge this and tag |
3 participants
This set of commits fixes the issue of #15 that I recently reported.
All tests were passing still on my end and this now allows me to run with out commenting out GREs. However once I started using
./vendor/bin/phpunitI got all sorts of errors in tests. I made an attempt at fixing most of them but I wasn't familiar enough with the packing and how to properly fix the remaining test that has issues.