Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Php7 compatibility update #16
This set of commits fixes the issue of #15 that I recently reported.
All tests were passing still on my end and this now allows me to run with out commenting out GREs. However once I started using
Well somehow running with the globally installed phpunit I wasn't seeing errors. running with vendor phpunit and I was seeing errors. First I tried an update to local phpunit, fix a few things and now there's only a single error left in the tests. While I was able to fix the issue I'm far too naiev to how this and php-parser package function to write a proper fix for the test. Also, since I have never used phrophecy with my unit tests, I'm a bit unfamiliar with how to use that correctly.
Other than requiring PHP 5.6 this patch set seems to be working correctly and is now passing all tests (where possible).
I'm unsure where or how this should be merged in as the updates to PHPunit now require a minimum of PHP 5.6. I personally don't think this is a big deal since anything prior is considered End Of Life.