Support custom conversions. Fixes #42 #89

Merged
merged 1 commit into from Jan 30, 2013

Projects

None yet

2 participants

@lassebunk

I made the solution a bit different from what I described in issue #42. I like this better because you use symbols instead of text.

Hope you can use it.

@rsl
Owner

this looks awesome. i'm gonna pull this to master. any chance you have some spare time to integrate this into the acts_as_url configuration stuff? there's new functionality there that lets you set acts_as_url config in an initializer for all yr models that this would be sweet in. i can prolly get to it next week if you don't have time. great functionality.

@rsl rsl merged commit f34632c into rsl:master Jan 30, 2013

1 check passed

Details default The Travis build passed
@lassebunk lassebunk deleted the unknown repository branch Jan 30, 2013
@lassebunk

Super. Do you think it could be a good idea to instead move all the custom conversions into an I18n translation hash? Then we could use the same translations throughout the code, and you wouldn't have translation logic inside the models.

@rsl
Owner

that makes a lot of sense. there's already some localization support in there [that no one seems to use]. it might could leverage that. and perhaps even encourage ppl to use it more. heh

@lassebunk

Hi again. How would you feel about moving to I18n if I make sure that the current implementation works some versions ahead? Thanks, /Lasse

@rsl
Owner

sounds good most likely. i'm not tied to the implementation here and if we're gonna change it drastically 2.0 [the next bump] is the place to do it. i don't use internationalization much so i may have missed the mark on my implementation the first go round anyhow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment