Skip to content

there were some issues with asking the user on a dirty document to save i #60

Merged
merged 1 commit into from Jun 20, 2011

3 participants

@schubter

there were some issues with asking the user on a dirty document to save it
most of the time it wasn't asking until you quit the app

this change now asks the user on closing a dirty tab if he wants to save, discard changes and close anyway or leave the tab open and handles the response properly.

@schubter schubter there were some issues with asking the user on a dirty document to sa…
…ve it

most of the time it wasn't asking until you quit the app

this change now asks the user on closing a dirty tab if he wants to save, discard changes and close anyway or leave the tab open and handles the response properly.
d1b1e56
@rsms rsms merged commit 6043dcb into rsms:master Jun 20, 2011
@parkr
parkr commented on d1b1e56 Jul 17, 2011

Wouldn't it be better to write canCloseContentsAt:(int)index this way? Don't want to be redundant!
Kod
I don't think we lose any optimization, because that whole if-statement will be skipped if shouldCloseTab is not YES. Just ought not to repeat code, y'know what I mean?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.