Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Made a few changes so that you don't have to write to file for cropping #49

Merged
merged 2 commits into from Sep 22, 2012

Conversation

Projects
None yet
4 participants
Contributor

jteplitz602 commented Jul 10, 2012

I made it so that crop now accepts srcData instead of a srcPath, and won't through an error if you don't send a dstPath, because that way you can send the resulting image to stdout.

Contributor

jteplitz602 commented Jul 10, 2012

Sorry some console logs leaked through there that I forgot to delete.

jhnlsn commented Sep 20, 2012

Exactly what I was looking for, thanks.

jhnlsn commented Sep 20, 2012

I'm guessing this package is no longer supported maintained? Possible you could hand this off to someone else?

bardu commented Sep 20, 2012

Agree, would be nice if someone could take over and further improve this useful package.

Contributor

jteplitz602 commented Sep 21, 2012

Definitely, it's a really nice package and doesn't look like it's been maintained in a while.

bardu commented Sep 21, 2012

@jteplitz602

Just wondering did you fork this package? If not could you do so and share?

bardu commented Sep 21, 2012

Cool, thanks.

Contributor

jteplitz602 commented Sep 21, 2012

No problem. I've also reached out to rsms on twitter to see if he still plans on maintaing this repo.

jhnlsn commented Sep 21, 2012

@bardu for future reference, jteplitz602 added a pull request to this ticket as you can see from those 2 commit's above. You are always able to grab the code from there or just use that repo instead of this one if the author never accepts the pull request. As in the case of this repo :)

@rsms rsms added a commit that referenced this pull request Sep 22, 2012

@rsms rsms Merge pull request #49 from jteplitz602/master
Made a few changes so that you don't have to write to file for cropping
1e88bac

@rsms rsms merged commit 1e88bac into rsms:master Sep 22, 2012

Owner

rsms commented Sep 22, 2012

Thanks for being patient guys

jhnlsn commented Sep 24, 2012

thank you!

@SamDecrock SamDecrock pushed a commit to SamDecrock/simple-imagemagick that referenced this pull request Dec 17, 2013

@rsms rsms Merge pull request #49 from jteplitz602/master
Made a few changes so that you don't have to write to file for cropping
f24f4a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment