New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

At certain conditions rsnapshot removes old backups without make new ones #141

Open
balodja opened this Issue May 22, 2016 · 3 comments

Comments

Projects
None yet
4 participants
@balodja
Copy link

balodja commented May 22, 2016

Let's suppose the config file having these lines:

retain alpha 3
retain beta 2

And the full spectra of backups is present, i.e.:

# ls snapshot_root
snapshot_root/alpha.0
snapshot_root/alpha.1
snapshot_root/alpha.2
snapshot_root/beta.0
snapshot_root/beta.1

Now let's do the rsnapshot beta, so rsnapshot removes the snapshot_root/beta.1, moves snapshot_root/beta.0 to snapshot_root/beta.1, and moves the snapshot_root/alpha.2 to snapshot_root/beta.0. So far, so good. The backups directory at this point is the following:

# ls snapshot_root
snapshot_root/alpha.0
snapshot_root/alpha.1
snapshot_root/beta.0
snapshot_root/beta.1

So if we now repeat the rsnapshot beta command, then rsnapshot does the same except from moving snapshot_root/alpha.2 to snapshot_root/beta.0. It complains about the absence of snapshot_root/alpha.2, but nevertheless moves snapshot_root/beta.0 without leaving any substitution for it. So backups directory turns out to be this:

# ls snapshot_root
snapshot_root/alpha.0
snapshot_root/alpha.1
snapshot_root/beta.1

This state seems to be faulty. I understand that repeating rsnapshot beta is not the intended use of rsnapshot, but IMHO it should not corrupt the backups.

@bebehei bebehei added the bug label May 22, 2016

@bebehei bebehei added this to the rsnapshot 1.5 milestone May 22, 2016

@bebehei bebehei self-assigned this May 22, 2016

@bebehei

This comment has been minimized.

Copy link
Member

bebehei commented May 22, 2016

Thank you for the bug report. 100% reproducible. I will care about.

@bebehei bebehei removed their assignment Feb 8, 2017

@m-osmani

This comment has been minimized.

Copy link

m-osmani commented Feb 9, 2017

Any updates here ?

@saas2813

This comment has been minimized.

Copy link

saas2813 commented Mar 6, 2017

Seems like this is related to issue #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment