Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
JDK9: Don't use JSR-305 dependency #423
There are several issues with using
JSR-305 is dormant, has been for a long while and shows no hope of ever producing an agreed set of annotations in our lifetime. Further more these annotations use
The JSR-305 group has not defined any official releases according to its jsr page so the only implementations is a seemingly random implementation provided by the FindBugs team. Even if the team where experts on the JSR (which some where) they are not official as there has been no vote and are not available from the JSR hompage - so the
Findbugs has been rebooted as Spotbugs and they are going to make a switch from JSR-305 to their own internal annotations in version 4.0.0 that do not break anything:
I think RSocket should consider switching to them in order not to pollute application dependencies with
I think rsocket-java is small enough that we can follow the lead of Kotlin and more widely adopted libraries like those from square
It seems it is viable to choose an alternative, but I would rather follow the lead of other projects rather than forge a new path.
@yschimke -> the links you provided are not an alternative, because they seem to be all based on
If you use modules with Java 9, two modules can't use the same package - things don't compile if you try to do it. There is an officially released JSR-250 that has the rights to use
Yep, I'm not actually disagreeing with you, I haven't researched the issue and you obviously have. All I'm suggesting is before rsocket-java moves, you should probably get our upstream dependencies to remove it.
After reactor-core removes it we can drop it also. Please reopen this issue once you work through this with projects like reactor-core.