fixes uncontrolled data sending in case of direct propagation of request from requester #595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est from requester Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
OlegDokuka
requested review from
mostroverkhov,
rdegnan,
robertroeser and
yschimke
bsideup
reviewed
Mar 12, 2019
bsideup
reviewed
Mar 12, 2019
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
OlegDokuka
added a commit
that referenced
this pull request
Mar 13, 2019
…est from requester (#595) * fixes uncontrolled data sending in case of direct propagation of request from requester * fixes timeout typo * replaces forEach with explicit loop * optimize access to limitableRequestPublisher Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
mostroverkhov
added a commit
that referenced
this pull request
May 18, 2019
…est from requester (#595)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provide a partial fix for #514 and reintroduce usage of
LimitableRequestPublisheras of its initial design.At a moment all connected
LimitableRequestPublisherreceives the same request size as from the connection. It means that upstream still an overflow UnboundProcessor but with less probability (it can happen in case we have super many requestChannel/requestStream connections which infinitely send data)In the future PRs we have to revise the implementation of UnboundedProcessor in order to have proper guarantees on overflow prevention.
Signed-off-by: Oleh Dokuka shadowgun@i.ua