Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Request N read #6

Merged
merged 1 commit into from Aug 31, 2019

Conversation

@tpeczek
Copy link
Contributor

commented Aug 18, 2019

Hi,

I'm playing with setting up RSocket.NET based server and while trying to access it from Java based client, the REQUEST_STREAM frame is always failing validation. The reason seems to be that Request N is not being read as big endian. I've applied the change and issue seems to be resolved.

@tpeczek

This comment has been minimized.

Copy link
Contributor Author

commented Aug 30, 2019

Hi @kbahr @dbarnett-netifi,

Any update on this?

@kbahr

This comment has been minimized.

Copy link
Contributor

commented Aug 31, 2019

That looks fine to me. I'll go ahead and merge and we can back it out if there's something I'm not aware of as a hitch.

@kbahr kbahr merged commit 1960d65 into rsocket:master Aug 31, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.