Permalink
Browse files

gem spec updates

* set homepage to github
* added group dependencies to gemspec
  • Loading branch information...
mwmitchell committed Nov 25, 2011
1 parent 573d7a2 commit 1c08f57ff392b79978a5d3b251da74af9ccb15d2
Showing with 6 additions and 1 deletion.
  1. +6 −1 rsolr.gemspec
View
@@ -10,10 +10,15 @@ Gem::Specification.new do |s|
s.version = RSolr.version
s.authors = ["Matt Mitchell", "Jeremy Hinegardner", "Mat Brown", "Mike Perham", "Nathan Witmer", "Peter Kieltyka", "Randy Souza", "shairon toledo", "shima", "Chris Beer", "Jonathan Rochkind"]
s.email = ["goodieboy@gmail.com"]
- s.homepage = "http://rubygems.org/gems/rsolr"
+ s.homepage = "https://github.com/mwmitchell/rsolr"
s.rubyforge_project = "rsolr"
s.files = `git ls-files`.split("\n")
s.test_files = `git ls-files -- {spec}/*`.split("\n")
s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
s.require_paths = ["lib"]
+
+ s.add_dependency 'builder', '~>2.1.2'
+ s.add_development_dependency 'rake', '~>0.9.2'
+ s.add_development_dependency 'rdoc', '~>3.9.4'
+ s.add_development_dependency 'rspec', '~>2.6.0'
end

10 comments on commit 1c08f57

@alindeman

This comment has been minimized.

Show comment Hide comment
@alindeman

alindeman Nov 26, 2011

Doesn't seem like this commit made the 1.0.4 release? Seems like the dependency info is needed. I'm seeing:

@adl9 ➜  sunspot rvm:(-ruby-1.9.2) git:(master) ✗ bundle show rsolr
/Users/alindeman/Documents/workspace/sunspot/sunspot/vendor/bundle/ruby/1.9.1/gems/rsolr-1.0.4
@adl9 ➜  sunspot rvm:(-ruby-1.9.2) git:(master) ✗ bundle exec rspec -b spec/integration/unicode_spec.rb
F

Failures:

  1) unicode characters correctly retrieves the string as UTF-8
     Failure/Error: Sunspot.remove_all
     LoadError:
       no such file to load -- builder
     # ./vendor/bundle/ruby/1.9.1/gems/rsolr-1.0.4/lib/rsolr/xml.rb:1:in `require'
     # ./vendor/bundle/ruby/1.9.1/gems/rsolr-1.0.4/lib/rsolr/xml.rb:1:in `<top (required)>'
     # ./vendor/bundle/ruby/1.9.1/gems/rsolr-1.0.4/lib/rsolr/client.rb:136:in `xml'
     # ./vendor/bundle/ruby/1.9.1/gems/rsolr-1.0.4/lib/rsolr/client.rb:131:in `delete_by_query'
     # ./lib/sunspot/indexer.rb:57:in `remove_all'
     # ./lib/sunspot/session.rb:178:in `remove_all'
     # ./lib/sunspot.rb:464:in `remove_all'
     # ./spec/integration/unicode_spec.rb:6:in `block (2 levels) in <top (required)>'

Doesn't seem like this commit made the 1.0.4 release? Seems like the dependency info is needed. I'm seeing:

@adl9 ➜  sunspot rvm:(-ruby-1.9.2) git:(master) ✗ bundle show rsolr
/Users/alindeman/Documents/workspace/sunspot/sunspot/vendor/bundle/ruby/1.9.1/gems/rsolr-1.0.4
@adl9 ➜  sunspot rvm:(-ruby-1.9.2) git:(master) ✗ bundle exec rspec -b spec/integration/unicode_spec.rb
F

Failures:

  1) unicode characters correctly retrieves the string as UTF-8
     Failure/Error: Sunspot.remove_all
     LoadError:
       no such file to load -- builder
     # ./vendor/bundle/ruby/1.9.1/gems/rsolr-1.0.4/lib/rsolr/xml.rb:1:in `require'
     # ./vendor/bundle/ruby/1.9.1/gems/rsolr-1.0.4/lib/rsolr/xml.rb:1:in `<top (required)>'
     # ./vendor/bundle/ruby/1.9.1/gems/rsolr-1.0.4/lib/rsolr/client.rb:136:in `xml'
     # ./vendor/bundle/ruby/1.9.1/gems/rsolr-1.0.4/lib/rsolr/client.rb:131:in `delete_by_query'
     # ./lib/sunspot/indexer.rb:57:in `remove_all'
     # ./lib/sunspot/session.rb:178:in `remove_all'
     # ./lib/sunspot.rb:464:in `remove_all'
     # ./spec/integration/unicode_spec.rb:6:in `block (2 levels) in <top (required)>'
@alindeman

This comment has been minimized.

Show comment Hide comment
@alindeman

alindeman Nov 26, 2011

Thoughts on making a release with these lines in the .gemspec?

Thoughts on making a release with these lines in the .gemspec?

@mwmitchell

This comment has been minimized.

Show comment Hide comment
@mwmitchell

mwmitchell Nov 26, 2011

Contributor

Yow. That's what happens if you eat too many turkey biscuit sandwiches, stuffing and pie.

I removed 1.0.4, and pushed 1.0.5 which contains the dependencies.

Matt

Contributor

mwmitchell replied Nov 26, 2011

Yow. That's what happens if you eat too many turkey biscuit sandwiches, stuffing and pie.

I removed 1.0.4, and pushed 1.0.5 which contains the dependencies.

Matt

@alindeman

This comment has been minimized.

Show comment Hide comment
@alindeman

alindeman Nov 26, 2011

Can't blame you on the turkey biscuits :) Thanks!! 👍

Can't blame you on the turkey biscuits :) Thanks!! 👍

@alindeman

This comment has been minimized.

Show comment Hide comment
@alindeman

alindeman Nov 26, 2011

Oh noes! Apparently Rails 3.1.x requires builder ~>3.0.0

Any chance the builder requirement could be >=2.1.2 instead of ~> ?

Ref: http://travis-ci.org/#!/sunspot/sunspot/builds/342797

Oh noes! Apparently Rails 3.1.x requires builder ~>3.0.0

Any chance the builder requirement could be >=2.1.2 instead of ~> ?

Ref: http://travis-ci.org/#!/sunspot/sunspot/builds/342797

@mwmitchell

This comment has been minimized.

Show comment Hide comment
@mwmitchell

mwmitchell Nov 26, 2011

Contributor

Sure. Give me a few minutes here...

Contributor

mwmitchell replied Nov 26, 2011

Sure. Give me a few minutes here...

@mwmitchell

This comment has been minimized.

Show comment Hide comment
@mwmitchell

mwmitchell Nov 26, 2011

Contributor
@alindeman

This comment has been minimized.

Show comment Hide comment
@mwmitchell

This comment has been minimized.

Show comment Hide comment
@mwmitchell

mwmitchell Nov 26, 2011

Contributor

Awesome, no problem :)

Contributor

mwmitchell replied Nov 26, 2011

Awesome, no problem :)

@nz

This comment has been minimized.

Show comment Hide comment
@nz

nz Nov 26, 2011

Contributor

❤️

Contributor

nz replied Nov 26, 2011

❤️

Please sign in to comment.