cyrptobox: work with OpenSSL-1.1 #2587
Closed
Conversation
ERR_load_EC_strings and friends don't need to be called with OpenSSL-1.1. Infact, on some platforms it causes a cyclic init which stops rspamd from working entirely. Luckily OpenSSL-1.1 should load these string automatically so we can avoid calling them.
|
I don't understand the drone failure above. Exit code 3 is not clear as to why it's failing.... |
|
Ignore drone.ci for now. I'm with you about the deprecation for these functions, however, I'm not completely sure about the proposed fix. I will check that later, thanks for report! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ERR_load_EC_strings and friends don't need to be called with
OpenSSL-1.1. Infact, on some platforms it causes a cyclic init
which stops rspamd from working entirely.
Luckily OpenSSL-1.1 should load these string automatically so we
can avoid calling them.