New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix specs failing with RSpec 3.4 #19

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@jkowens

jkowens commented Jan 12, 2016

Fixes #18. RSpec 3.4 must have updated the printed failure message format.

@searls

This comment has been minimized.

searls commented Jan 12, 2016

Thanks for this. RSpec's output is a lot meatier than it used to be if you really read it, so I'm going to keep investigating before I merge just to get the test passing in case we have any control over the message (or can suggest improvements to the RSpec team)

@jkowens

This comment has been minimized.

jkowens commented Jan 12, 2016

No problem, that makes sense. I figured this PR would at least help point out the reason for the failures.

@searls searls referenced this pull request Jan 12, 2016

Closed

Specs fail with RSpec >= 3.1 #18

@searls

This comment has been minimized.

searls commented Jan 12, 2016

Closing based on this rationale #18 (comment)

@searls searls closed this Jan 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment