Adds autotest code extracted from rspec-rails #6

Merged
merged 2 commits into from Aug 10, 2013

Conversation

Projects
None yet
4 participants
Contributor

alindeman commented Aug 9, 2013

No description provided.

Coverage Status

Coverage decreased (-0%) when pulling ea7926d on rspec-rails into e6748c8 on master.

alindeman added a commit to rspec/rspec-rails that referenced this pull request Aug 9, 2013

Owner

JonRowe commented Aug 10, 2013

The path I went through to check this worked a-ok with plain rspec was to run a dummy project on 2-14, then 2-99 with deprecation warning, then pulling in this to remove warning, then running plain 3. This was useful because it caught a few hangups (like require orders of files, constant usage and the rspec command) which I missed (and the specs missed). Have you done something similar? Otherwise LGTM

Contributor

alindeman commented Aug 10, 2013

Good call. I thought I had done all those things, but just ran through them again in the context of a Rails project. It works as we'd expect (2-99 gets a deprecation, master doesn't work at all, master works again with this gem)

alindeman added a commit that referenced this pull request Aug 10, 2013

Merge pull request #6 from rspec/rspec-rails
Adds autotest code extracted from rspec-rails

@alindeman alindeman merged commit 318f09e into master Aug 10, 2013

1 check passed

default The Travis CI build passed
Details

@alindeman alindeman deleted the rspec-rails branch Aug 10, 2013

Contributor

alindeman commented Aug 10, 2013

@myronmarston, we might want to push another release/prerelease to gemcutter?

Owner

myronmarston commented Aug 10, 2013

@myronmarston, we might want to push another release/prerelease to gemcutter?

I just added you and @JonRowe as owners. I'll leave you two to it :).

Contributor

alindeman commented Aug 11, 2013

Great. Decided to hold off a bit until RSpec 3 is imminent after discussing it with @samphippen. Anyone who needs this gem will also be running the git version of rspec-*.

Owner

JonRowe commented Aug 12, 2013

FYI, this will be needed when 2-99 drop's to remove the warning, I'm curious why @samphippen is against dropping a pre release? (Git repo's in my mind make testing combinations of gem's slightly harder...)

Contributor

alindeman commented Aug 12, 2013

I could go either way. @samphippen want to weigh in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment