Fix exit_status after Exception raised in before :all hook

- Closes #301. - Closes #302.
rspec · Feb 14, 2011 · 79273a7 · 79273a7
1 parent d832c61
commit 79273a7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/lib/rspec/core/example_group.rb b/lib/rspec/core/example_group.rb
@@ -248,6 +248,7 @@ def self.fail_filtered_examples(exception, reporter)
           child.fail_filtered_examples(exception, reporter)
           reporter.example_group_finished(child)
         end
+        false
       end
 
       def self.fail_fast?

diff --git a/spec/rspec/core/example_group_spec.rb b/spec/rspec/core/example_group_spec.rb
@@ -387,7 +387,7 @@ module RSpec::Core
         group = ExampleGroup.describe
         group.before(:each) { raise "error in before each" }
         example = group.example("equality") { 1.should == 2}
-        group.run
+        group.run.should == false
 
         example.metadata[:execution_result][:exception].message.should == "error in before each"
       end
@@ -396,7 +396,7 @@ module RSpec::Core
         group = ExampleGroup.describe
         group.before(:all) { raise "error in before all" }
         example = group.example("equality") { 1.should == 2}
-        group.run
+        group.run.should == false
 
         example.metadata.should_not be_nil
         example.metadata[:execution_result].should_not be_nil