From cf48b93f1d2aec2889ff372ab8bd75ff56fdf846 Mon Sep 17 00:00:00 2001 From: Myron Marston Date: Wed, 1 Apr 2015 00:02:19 -0700 Subject: [PATCH] Standardize bisect progress output on "failing" over "failed". --- lib/rspec/core/formatters/bisect_progress_formatter.rb | 2 +- spec/integration/bisect_spec.rb | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/rspec/core/formatters/bisect_progress_formatter.rb b/lib/rspec/core/formatters/bisect_progress_formatter.rb index bcf4288ca3..3b12c219ef 100644 --- a/lib/rspec/core/formatters/bisect_progress_formatter.rb +++ b/lib/rspec/core/formatters/bisect_progress_formatter.rb @@ -19,7 +19,7 @@ def bisect_starting(notification) end def bisect_original_run_complete(notification) - failures = Helpers.pluralize(notification.failed_example_ids.size, "failed example") + failures = Helpers.pluralize(notification.failed_example_ids.size, "failing example") non_failures = Helpers.pluralize(notification.non_failing_example_ids.size, "non-failing example") output.puts " (#{Helpers.format_duration(notification.duration)})" diff --git a/spec/integration/bisect_spec.rb b/spec/integration/bisect_spec.rb index c63a7fbf88..e46663e3b1 100644 --- a/spec/integration/bisect_spec.rb +++ b/spec/integration/bisect_spec.rb @@ -22,7 +22,7 @@ def bisect(cli_args, expected_status=nil) expect(output).to eq(<<-EOS.gsub(/^\s+\|/, '')) |Bisect started using options: "spec/rspec/core/resources/order_dependent_specs.rb --order defined" |Running suite to find failures... (n.nnnn seconds) - |Starting bisect with 1 failed example and 21 non-failing examples. + |Starting bisect with 1 failing example and 21 non-failing examples. | |Round 1: searching for 11 non-failing examples (of 21) to ignore: .. (n.nnnn seconds) |Round 2: searching for 6 non-failing examples (of 11) to ignore: . (n.nnnn seconds) @@ -138,7 +138,7 @@ def bisect_round_finished(notification) expect(output).to eq(<<-EOS.gsub(/^\s+\|/, '')) |Bisect started using options: "spec/rspec/core/resources/order_dependent_specs.rb --order defined" |Running suite to find failures... (n.nnnn seconds) - |Starting bisect with 1 failed example and 21 non-failing examples. + |Starting bisect with 1 failing example and 21 non-failing examples. | |Round 1: searching for 11 non-failing examples (of 21) to ignore: .. (n.nnnn seconds) |Round 2: searching for 6 non-failing examples (of 11) to ignore: .