Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Use File::PATH_SEPARATOR

- thanks to Luis Lavena for the pointer
- Closes #289.
  • Loading branch information...
commit dbbb891991330f554c556cf0cecf020d8e587178 1 parent ada3a5d
@dchelimsky dchelimsky authored
Showing with 1 addition and 1 deletion.
  1. +1 −1  lib/rspec/core/rake_task.rb
View
2  lib/rspec/core/rake_task.rb
@@ -161,7 +161,7 @@ def spec_command
cmd_parts << "bundle exec" if gemfile? unless skip_bundler
cmd_parts << runner
if rcov
- cmd_parts << ["-Ispec:lib", rcov_opts]
+ cmd_parts << ["-Ispec#{File::PATH_SEPARATOR}lib", rcov_opts]
else
cmd_parts << rspec_opts
end

2 comments on commit dbbb891

@atambo

This change breaks jruby on windows support as File::PATH_SEPARATOR returns ";" and results in:

'require': no such file to load -- spec_helper (LoadError)

when running the spec:rcov task.

Reverting this commit fixed the problem. Created issue for this here:

https://github.com/rspec/rspec-core/issues/issue/307

@sundbp

I'm running into this as well.
rcov explicitly says that it always uses ':' in its help, so I think using PATH_SEPARATOR is wrong.

Please sign in to comment.
Something went wrong with that request. Please try again.